Closed clamoriniere1A closed 5 years ago
@sdminonne you can see here the error about "insecure registry" when trying to start oc cluster up
in travisci: https://travis-ci.org/clamoriniere1A/workflow-controller/jobs/342369190
Merging #55 into master will increase coverage by
0.03%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 29.77% 29.81% +0.03%
==========================================
Files 17 17
Lines 1639 1637 -2
==========================================
Hits 488 488
+ Misses 1115 1113 -2
Partials 36 36
Impacted Files | Coverage Δ | |
---|---|---|
pkg/controller/controller_util.go | 38.02% <0%> (+1.04%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a374cba...9f83025. Read the comment docs.
@sdminonne let me know if you are happy with the current state of this PR.
thanks will merge on green
Thanks @clamoriniere1A, having a look