search

AmadeusITGroup / workflow-controller

Kubernetes workflow controller
Apache License 2.0
24 stars 15 forks source link

Generate UpdateStatus for workflow and CronWorkflow and install CronW… #60

Closed sdminonne closed 6 years ago

sdminonne commented 6 years ago

Generate UpdateStatus for workflow and CronWorkflow. Install CronWorkflow CRD Create skeleton for cronWorkflowController

clamoriniere1A commented 6 years ago

@sdminonne you need to add the CRD creation into the Helm chart.

codecov-io commented 6 years ago

Codecov Report

Merging #60 into master will decrease coverage by 10.63%. The diff coverage is 1.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #60       +/-   ##
==========================================
- Coverage   40.23%   29.6%   -10.64%     
==========================================
  Files           9      14        +5     
  Lines         835    1135      +300     
==========================================
  Hits          336     336               
- Misses        473     773      +300     
  Partials       26      26
Impacted Files Coverage Δ
pkg/controller/job_control.go 0% <ø> (ø) :arrow_up:
pkg/api/cronworkflow/v1/register.go 0% <ø> (ø)
pkg/api/cronworkflow/v1/validation.go 0% <0%> (ø)
pkg/api/cronworkflow/v1/default.go 0% <0%> (ø)
pkg/controller/cronworkflow.go 0% <0%> (ø)
pkg/controller/workflow.go 43.71% <100%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e9cc0b7...300bf02. Read the comment docs.

sdminonne commented 6 years ago

@clamoriniere1A PTA

sdminonne commented 6 years ago

@clamoriniere1A comments addressed. Would like to squash and merge. Mind quickly relook at it?

clamoriniere1A commented 6 years ago

/lgtm

sdminonne commented 6 years ago

Awesome thanks!