search

AmadeusITGroup / workflow-controller

Kubernetes workflow controller
Apache License 2.0
24 stars 15 forks source link

[WIP] CronWorkflow Controller #63

Closed sdminonne closed 5 years ago

sdminonne commented 6 years ago

Don't waste time reviewing. Going to change anyway.

codecov-io commented 6 years ago

Codecov Report

Merging #63 into master will increase coverage by 14.16%. The diff coverage is 38.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #63       +/-   ##
===========================================
+ Coverage    29.6%   43.76%   +14.16%     
===========================================
  Files          14        6        -8     
  Lines        1135      393      -742     
===========================================
- Hits          336      172      -164     
+ Misses        773      207      -566     
+ Partials       26       14       -12
Impacted Files Coverage Δ
pkg/api/cronworkflow/v1/zz_generated.deepcopy.go 0% <0%> (ø) :arrow_up:
pkg/api/cronworkflow/validation/validation.go 46.93% <46.93%> (ø)
pkg/api/workflow/validation/validation.go 78.75% <75%> (ø)
pkg/controller/job_control.go
pkg/api/workflow/v1/register.go
pkg/api/workflow/v1/default.go

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c307620...66d168e. Read the comment docs.

sdminonne commented 5 years ago

closing in favour of #76