Closed davidc-donorschoose closed 6 years ago
@davidc-donorschoose may I ask you to restart the travis build for this PR?
I'm not sure what you need me to do. I clicked through your travis-ci.org link and don't see anything obvious.
Merging #68 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #68 +/- ##
======================================
Coverage 29.6% 29.6%
======================================
Files 14 14
Lines 1135 1135
======================================
Hits 336 336
Misses 773 773
Partials 26 26
Impacted Files | Coverage Δ | |
---|---|---|
pkg/controller/controller_util.go | 40.29% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 724977b...515d736. Read the comment docs.
@davidc-donorschoose, finally I was able to restart myself the travis-ci job, and it runs properly. So I will merge now you PR. Thanks again for the fix.
This has been working for us for a while. I am looping over the range
template.Spec.Template.ObjectMeta.Labels
, which is where I find thetemplate.metadata.labels
from my workflow manifest yaml. Those labels are appearing on the Job objects that are created for my Workflow.