search

AmadeusITGroup / workflow-controller

Kubernetes workflow controller
Apache License 2.0
24 stars 15 forks source link

Start DaemonSetJob implementation with API resource definition #70

Closed clamoriniere1A closed 5 years ago

clamoriniere1A commented 5 years ago

This PR contains the definition of the DaemonSetJob API resource

codecov-io commented 5 years ago

Codecov Report

Merging #70 into master will increase coverage by 0.31%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage    29.6%   29.91%   +0.31%     
==========================================
  Files          14       14              
  Lines        1135     1123      -12     
==========================================
  Hits          336      336              
+ Misses        773      761      -12     
  Partials       26       26
Impacted Files Coverage Δ
pkg/api/workflow/v1/default.go 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5bafacc...f59eac3. Read the comment docs.

sdminonne commented 5 years ago

@clamoriniere1A should I review this? Or do you want me to wait for you to remove 'WIP'?

clamoriniere1A commented 5 years ago

@clamoriniere1A should I review this? Or do you want me to wait for you to remove 'WIP'?

You can start reviewing it. This PR is only the skeleton of the new controller

sdminonne commented 5 years ago

Started. Looks good but I need to run through all code, though...

sdminonne commented 5 years ago

@clamoriniere1A sorry to ask this: may you split into three commits:

clamoriniere1A commented 5 years ago

@clamoriniere1A sorry to ask this: may you split into three commits:

  • api
  • generated code
  • controller stub thanks

PR updated with 3 commits

sdminonne commented 5 years ago

LGTM. Thanks. Merging since @EricMountain-1A comment is not on types.go.