Closed clamoriniere1A closed 5 years ago
Merging #70 into master will increase coverage by
0.31%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 29.6% 29.91% +0.31%
==========================================
Files 14 14
Lines 1135 1123 -12
==========================================
Hits 336 336
+ Misses 773 761 -12
Partials 26 26
Impacted Files | Coverage Δ | |
---|---|---|
pkg/api/workflow/v1/default.go | 0% <0%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5bafacc...f59eac3. Read the comment docs.
@clamoriniere1A should I review this? Or do you want me to wait for you to remove 'WIP'?
@clamoriniere1A should I review this? Or do you want me to wait for you to remove 'WIP'?
You can start reviewing it. This PR is only the skeleton of the new controller
Started. Looks good but I need to run through all code, though...
@clamoriniere1A sorry to ask this: may you split into three commits:
@clamoriniere1A sorry to ask this: may you split into three commits:
- api
- generated code
- controller stub thanks
PR updated with 3 commits
LGTM. Thanks.
Merging since @EricMountain-1A comment is not on types.go
.
This PR contains the definition of the DaemonSetJob API resource