Closed clamoriniere1A closed 5 years ago
Merging #74 into master will increase coverage by
3.94%
. The diff coverage is26.24%
.
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
+ Coverage 25.82% 29.77% +3.94%
==========================================
Files 16 17 +1
Lines 1301 1639 +338
==========================================
+ Hits 336 488 +152
- Misses 939 1115 +176
- Partials 26 36 +10
Impacted Files | Coverage Δ | |
---|---|---|
pkg/controller/job_control.go | 0% <0%> (ø) |
:arrow_up: |
pkg/controller/cronworkflow.go | 0% <0%> (ø) |
:arrow_up: |
pkg/controller/workflow.go | 43.97% <14.28%> (+0.26%) |
:arrow_up: |
pkg/controller/controller_util.go | 36.98% <21.42%> (-3.32%) |
:arrow_down: |
pkg/controller/daemonsetjob.go | 33.33% <25.36%> (+33.33%) |
:arrow_up: |
pkg/garbagecollector/garbagecollector.go | 62.16% <40%> (ø) |
:arrow_up: |
pkg/garbagecollector/daemonsetjob_gc.go | 62.16% <62.16%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 824e527...437c648. Read the comment docs.
Mind squash together the first two commits?
awesome thanks
lgtm If you can/want squash I'd merge it. Thanks again!
Implement: #71