search

AmadeusITGroup / workflow-controller

Kubernetes workflow controller
Apache License 2.0
24 stars 15 forks source link

cron workflow controller #76

Closed sdminonne closed 5 years ago

sdminonne commented 5 years ago

going to close #63 in favour of this

codecov-io commented 5 years ago

Codecov Report

Merging #76 into master will increase coverage by 4.16%. The diff coverage is 41.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   33.86%   38.03%   +4.16%     
==========================================
  Files          17       20       +3     
  Lines        1695     1922     +227     
==========================================
+ Hits          574      731     +157     
- Misses       1073     1128      +55     
- Partials       48       63      +15
Impacted Files Coverage Δ
pkg/controller/cronworkflow.go 0% <0%> (ø) :arrow_up:
pkg/controller/common.go 23.52% <0%> (ø) :arrow_up:
pkg/controller/cronworkflow_util.go 42.1% <42.1%> (ø)
pkg/api/cronworkflow/validation/validation.go 46.93% <46.93%> (ø)
pkg/api/workflow/validation/validation.go 78.75% <78.75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b80d7d7...9d01232. Read the comment docs.

sdminonne commented 5 years ago

@cedriclam may you review this? I think I'm ready for a review.

sdminonne commented 5 years ago

@EricMountain-1A if you've cycles it would be great having your opinion as well. Thanks

sdminonne commented 5 years ago

@EricMountain-1A thanks!

sdminonne commented 5 years ago

Updated squashing all code keeping vendoring in another commit. Hope it helps. Thanks

sdminonne commented 5 years ago

@cedriclam please whenever you'll merge don't squash vendor and human defined code