Closed clamoriniere1A closed 5 years ago
Merging #78 into master will increase coverage by
4.33%
. The diff coverage is40.9%
.
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 29.79% 34.13% +4.33%
==========================================
Files 17 17
Lines 1638 1673 +35
==========================================
+ Hits 488 571 +83
+ Misses 1114 1056 -58
- Partials 36 46 +10
Impacted Files | Coverage Δ | |
---|---|---|
pkg/controller/controller_util.go | 45.83% <100%> (+8.33%) |
:arrow_up: |
pkg/controller/common.go | 23.52% <100%> (+23.52%) |
:arrow_up: |
pkg/controller/job_control.go | 10.93% <33.33%> (+10.93%) |
:arrow_up: |
pkg/controller/daemonsetjob.go | 48.26% <33.33%> (+14.93%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 457cc08...e0f0e96. Read the comment docs.
@sdminonne let me know if you have others remarks after my changes
May be 30s is not enough :)
thanks!
Issue: #71