Closed sdminonne closed 5 years ago
Merging #81 into master will not change coverage. The diff coverage is
0%
.
@@ Coverage Diff @@
## master #81 +/- ##
=======================================
Coverage 34.13% 34.13%
=======================================
Files 17 17
Lines 1673 1673
=======================================
Hits 571 571
Misses 1056 1056
Partials 46 46
Impacted Files | Coverage Δ | |
---|---|---|
pkg/controller/daemonsetjob.go | 48.26% <0%> (ø) |
:arrow_up: |
pkg/controller/workflow.go | 43.97% <0%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9bc7bed...a23ff5a. Read the comment docs.
Merging #81 into master will not change coverage. The diff coverage is
0%
.
@@ Coverage Diff @@
## master #81 +/- ##
=======================================
Coverage 34.13% 34.13%
=======================================
Files 17 17
Lines 1673 1673
=======================================
Hits 571 571
Misses 1056 1056
Partials 46 46
Impacted Files | Coverage Δ | |
---|---|---|
pkg/controller/daemonsetjob.go | 48.26% <0%> (ø) |
:arrow_up: |
pkg/controller/workflow.go | 43.97% <0%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9bc7bed...14eb3f0. Read the comment docs.
Hi workflowers,
2 things in this PR:
The first one is simple: when an item has been deleted stop log the error raising error to
v(4)
Second one: unluckily some of our test e2e are a little bit too promiscuous while checking if workflow or daemonsetjob has been created. Goal of this PR is to restrict the scope. Why? Developing cronworklows I realized that sometime some workflows generated by cronworkflows were picked up by the workflows.list funcs The idea is: stop list simply get what is needed.
Hope it's clear.