search

AmadeusITGroup / workflow-controller

Kubernetes workflow controller
Apache License 2.0
24 stars 15 forks source link

improve cleaning in e2e #84

Closed sdminonne closed 5 years ago

sdminonne commented 5 years ago

Improving cleaning for workflow jobs in e2e, only aesthetic for daemonsetJob

codecov[bot] commented 5 years ago

Codecov Report

Merging #84 into master will increase coverage by 0.65%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   33.27%   33.92%   +0.65%     
==========================================
  Files          17       17              
  Lines        1725     1683      -42     
==========================================
- Hits          574      571       -3     
+ Misses       1103     1066      -37     
+ Partials       48       46       -2
Impacted Files Coverage Δ
pkg/controller/job_control.go 10.6% <0%> (+1.03%) :arrow_up:
pkg/controller/daemonsetjob.go 48.26% <0%> (+1.37%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0fb9be9...c6145f8. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #84 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   33.27%   33.27%           
=======================================
  Files          17       17           
  Lines        1725     1725           
=======================================
  Hits          574      574           
  Misses       1103     1103           
  Partials       48       48

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0fb9be9...c6145f8. Read the comment docs.