search

AmadeusITGroup / workflow-controller

Kubernetes workflow controller
Apache License 2.0
24 stars 15 forks source link

to add informers, listers and client generation #9

Closed sdminonne closed 7 years ago

sdminonne commented 7 years ago

@clamoriniere1A @EricMountain-1A

codecov-io commented 7 years ago

Codecov Report

Merging #9 into master will increase coverage by 0.13%. The diff coverage is 51.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   24.42%   24.55%   +0.13%     
==========================================
  Files           8        8              
  Lines         823      794      -29     
==========================================
- Hits          201      195       -6     
+ Misses        606      585      -21     
+ Partials       16       14       -2
Impacted Files Coverage Δ
pkg/controller/job_control.go 0% <ø> (ø) :arrow_up:
pkg/api/workflow/v1/deepcopy_generated.go 0% <ø> (ø)
pkg/controller/controller_util.go 0% <ø> (ø) :arrow_up:
pkg/api/workflow/v1/default.go 0% <ø> (ø)
pkg/api/workflow/v1/validation.go 78.75% <ø> (ø)
pkg/api/workflow/v1/util.go 87.5% <ø> (ø)
pkg/api/workflow/v1/register.go 0% <0%> (ø)
pkg/controller/controller.go 17.13% <56%> (-0.2%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1589403...95dc91b. Read the comment docs.

clamoriniere1A commented 7 years ago

/lgtm

sdminonne commented 7 years ago

@EricMountain-1A feedback integrated (and squashed). Going to merge on green. Thanks