Recipe app Review - Githubissues

AmaliaGM commented 1 year ago

https://github.com/users/AmaliaGM/projects/2/views/1

NOTE TO THE CODE REVIEWER : Hi, There are two of us developing this project. Have a nice day.

Project requirements

Join a Zoom call with your team. Only one person needs to create the board on behalf of the entire team but everybody should help during the call.
Create an empty repository for your group project.
Open the GitHub project (Kanban board) in your team repo (set up the same columns as in previous group projects).
Open project requirements and read them carefully.
Create tasks on your Kanban board based on the project requirements.
Each task should be a separate card that:
- Has a descriptive title.
- Has the number of points in the [Xpt] prefix. That number should indicate the number of points that show how complex the task is. 1 point = 1 hour of estimated work. You shouldn't change the points after dividing up cards, even if the actual work takes longer.
- Has a description of the task.
Each of the team members should assign themselves to the cards (and time estimate distributions should be fair
- no single person should be doing all of the most time-consuming tasks).
- Decide who will be the assignee for the cards marked as group tasks. All cards on your Kanban board should have assignees. NOTE you should distribite tasks in a way that gives each team member a chance to work with different parts of RoR. The number of assigned points should be equal (+/- 5 points) for each member.
Open a new issue in your repository
- In its description, paste a link to your GitHub project.
- Add a note telling the reviewer how many people there are in your team.

FrederickMih commented 1 year ago

Hi :raising_hand: Team,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Screenshot from 2022-10-20 09-38-51

Highlights

Descriptive issue summary :+1:

Required Changes ♻️

[ ] Hi team, let's kindly stick to the requirements of this project. Your board should have four columns, not three. Your board is missing the In Review column that's supposed to be found next to the In Progress column. Let's kindly fix it.
[ ] Right now, some of your cards don't have a number of points in the [Xpt] prefix as you can see on the screenshot below:
[ ] Let's kindly provide the full description for each task. Once more check out the project requirements and provide a full description of a task. Nothing should be missing from he requirement list.

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

rloterh commented 1 year ago

Status: Approved :heavy_check_mark:

Hi Team,

Your task is complete! 🍾🍾 Congratulations! 🎉💯🌟

Highlights 👍

Board has required number of tasks
Fair distribution of tasks

Keep soaring higher! 💻 🍷 🚀