search

AmanNegi / FreshNest

A platform that connects local producers directly with consumers seeking fresh produce.
https://fresh-nest.netlify.app
GNU Affero General Public License v3.0
23 stars 39 forks source link

Add Loading and Validation in Login/SignUp #124

Closed ayobamiseun closed 1 year ago

ayobamiseun commented 1 year ago

I also repositioned the function for both login and signup.

Fixes: #123

AmanNegi commented 1 year ago

@ayobamiseun It's always preferred to create a new branch for every PR you make, it's not suggested to use the main branch. Feel free to create a new PR from a separate branch.

ayobamiseun commented 1 year ago

@AmanNegi should i push to the branch dev-react or test ??

AmanNegi commented 1 year ago

@ayobamiseun you should create your branch let's say you are working on adding a loading indicator on the Loading/SignUp page. You could name your branch as auth-add-suspense or auth-add-loading. Once you are done with this issue, the branch will be merged with the main branch and then if you work on some new issue you should create a new branch appropriately.

Learn more: https://opensource.guide/how-to-contribute/#opening-a-pull-request

ayobamiseun commented 1 year ago

the changes are good but instead of giving only check if the login length are filled or not we should check if it is genuine or not

that will be coming from an api. if i can get the status code i can also handle that. also check if an account already exists or not.

AmanNegi commented 1 year ago

the changes are good but instead of giving only check if the login length are filled or not we should check if it is genuine or not

@sumit639-code sounds appropriate to me. We can use formik for this.

AmanNegi commented 1 year ago

that will be coming from an api. if i can get the status code i can also handle that. also check if an account already exists or not.

@ayobamiseun We do handle errors coming from the APIs and show them as an error. What @sumit639-code meant to say was that we should add a layer of validation in the front end itself. I guess, we can use Formik to achieve that easily.

AmanNegi commented 1 year ago

Shifted to #130.