Enhance Error Handling and Implement Required Fields for Auth

[ayobamiseun]

We have identified the need to enhance the error handling mechanism in our authentication system. Additionally, we need to implement required fields for authentication to ensure the security and usability of our application.

Error Handling Enhancement:

Currently, our application does not provide adequate error feedback to users during authentication. When authentication fails, users are not informed about the specific issue, which can lead to confusion and frustration.

Proposed Changes for Error Handling:

Implement clear and informative error messages for different authentication failure scenarios. Log errors on the server for debugging and monitoring purposes. Improve the user interface to display error messages prominently and guide users on how to resolve authentication issues.

Required Fields for Authentication:

To enhance the security of our authentication system, we need to ensure that certain fields are mandatory during the registration and login processes. This will help prevent incomplete or inaccurate user profiles and improve the overall user experience.

[AmanNegi]

@ayobamiseun This seems like a copy of https://github.com/AmanNegi/FreshNest/issues/125. Let me know if I am wrong.

[ayobamiseun]

@ayobamiseun This seems like a copy of #125. Let me know if I am wrong.

i just checked, it's same thing. i will just wait for it to be implemented cause it has not yet been done.

[AmanNegi]

@ayobamiseun While that issue is about frontend validation, we still have an error in the backend. If you want you can work on it and update this issue.

Basically, the issue is that when Node.js returns a 400 response code our React frontend throws an error. To avoid this issue we use the function getErrorResponse, which returns a 200 response but has a status code and error message inside the body. It seems that when an error is found we are directly returning a 400 response code which is causing the issue and we are not getting a toast on the front-end side.

TODO's:

• [ ] Replace all res.status(400) or res.status(200) with appropriate functions getErrorResponse or getSuccessResponse.

Reference:

• https://github.com/AmanNegi/FreshNest/blob/ce8d1ea02d8edc6906a82f8be88889a4a02a58f3/backend/routes/auth.js#L19

[Smajdalf530]

Hi, could you please assign this issue to me ?

[ayobamiseun]

let me

@ayobamiseun While that issue is about frontend validation, we still have an error in the backend. If you want you can work on it and update this issue.

Basically, the issue is that when Node.js returns a 400 response code our React frontend throws an error. To avoid this issue we use the function getErrorResponse, which returns a 200 response but has a status code and error message inside the body. It seems that when an error is found we are directly returning a 400 response code which is causing the issue and we are not getting a toast on the front-end side.

TODO's:

• [ ] Replace all res.status(400) or res.status(200) with appropriate functions getErrorResponse or getSuccessResponse.

Reference:

• https://github.com/AmanNegi/FreshNest/blob/ce8d1ea02d8edc6906a82f8be88889a4a02a58f3/backend/routes/auth.js#L19

I believe I've already resolved this issue, but I'm unable to test it because I can't use the local API route due to CORS issues

@ayobamiseun While that issue is about frontend validation, we still have an error in the backend. If you want you can work on it and update this issue.

Basically, the issue is that when Node.js returns a 400 response code our React frontend throws an error. To avoid this issue we use the function getErrorResponse, which returns a 200 response but has a status code and error message inside the body. It seems that when an error is found we are directly returning a 400 response code which is causing the issue and we are not getting a toast on the front-end side.

TODO's:

• [ ] Replace all res.status(400) or res.status(200) with appropriate functions getErrorResponse or getSuccessResponse.

Reference:

• https://github.com/AmanNegi/FreshNest/blob/ce8d1ea02d8edc6906a82f8be88889a4a02a58f3/backend/routes/auth.js#L19

I believe I've already resolved this issue, but I'm unable to test it because I can't use the local API route due to CORS issues. you can check my PR