search

AmanNegi / FreshNest

A platform that connects local producers directly with consumers seeking fresh produce.
https://fresh-nest.netlify.app
GNU Affero General Public License v3.0
22 stars 36 forks source link

Fix #185 : Remove timer's live property #192

Closed MohitKambli closed 6 months ago

MohitKambli commented 6 months ago

Hello, Hope you're doing well. In order to solve issue #185, I have simply added the live property to the TimeAgo component and set it to false. The reason for doing this is to remove the live timer which actually looked like "1, 2, 3 seconds ago" before introducing the mentioned property and setting it to false. The default value of this property is true. For more details regarding the property and react-timeago component, one can refer this link. If at all there is anything required from my end, then do let me know. Sincere apologies for my mistakes if you find any.

Thanks and Regards, Mohit Kambli

AmanNegi commented 6 months ago

@MohitKambli could you pull from main branch and push again, your branch seems to be 3 commits behind currently.

MohitKambli commented 6 months ago

Hello @AmanNegi, I pulled the latest changes and pushed the code changes back. Does that look fine to you?

Regards, Mohit Kambli

AmanNegi commented 6 months ago

@MohitKambli Could you squash the 4 commits into one commit. Also try git pull again, there might have been more merges.

MohitKambli commented 6 months ago

Hello @AmanNegi, I tried to squash the commits into one by following the rebase process. I am not sure if that actually happened or no. Could you please help me with that? Sincere apologies for causing the trouble. I need to work on Git properly.

Regards, Mohit Kambli

AmanNegi commented 6 months ago

@MohitKambli It's always a good idea to create a new branch for new PR. So feel free to create a new branch from main and create a new PR with the changes.