AmanNegi / FreshNest

A platform that connects local producers directly with consumers seeking fresh produce.
https://fresh-nest.netlify.app
GNU Affero General Public License v3.0
22 stars 36 forks source link

fix: added password Hashing #199

Closed aashutosh148 closed 4 weeks ago

aashutosh148 commented 1 month ago

Changes

Testing

Dependencies

Please review and let me know if any further changes are needed.

AmanNegi commented 4 weeks ago

@aashutosh148 I'd suggest changing the title to include of the standard convention like (chore, feat, docs, etc) this can be done easily currently using the edit button next to the title.

Another suggestion is to keep the branch name something like feat/implement-password-hashing or some conventional prefix that explains the impact of the PR. (PS: currently you wouldn't be able to change it, ensure it from next time).

Here's more on the conventional prefix part: https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716

aashutosh148 commented 4 weeks ago

I have made the necessary changes. Please let me know if any more changes are needed

I'll keep that in mind, the other thing you mentioned.