search

AmandaDiscord / Volcano

A light-weight LavaLink compatible replacement
MIT License
71 stars 15 forks source link

Spotify options #2

Closed Ayeven closed 2 years ago

Ayeven commented 3 years ago

https://www.npmjs.com/package/spotify-url-info

PapiOphidian commented 3 years ago

I have my own code to scrape spotify metadata which I could implement into this project, but that would make going back to lavalink incompatible which could lead to some confusion. I was debating if I should implement or not, but I can give it more thought. I'll leave this issue open for now. Feel free to discuss more or close whenever

PapiOphidian commented 3 years ago

I tried to possibly add backwards compatible-ish support for this so that lavalink would reference YouTube as the source, but providing links to Spotify playlists or albums would impose gettings tracks recursively on all tracks in the playlist/album which could cause the Volcano instance's IP to get rate limited.

If you really wanted to provide a Spotify implementation without any extra dependencies, I would reference https://github.com/AmandaDiscord/Amanda/blob/feb402725297fe8f33397fe128c906bd004e7e5d/commands/music/common.js#L756

Ayeven commented 3 years ago

After thinking back again on this idea. That would be need to do 2 http request 1 to spotify, 1 to youtube. For personal use, it is fine, but for public, might be not a good idea

PapiOphidian commented 2 years ago

I'll close this issue and either recommend my suggestion Amanda uses or what I've seen other people use which is erela.js with better-erela.js-spotify