AmandaDiscord / Volcano

A light-weight LavaLink compatible replacement
MIT License
71 stars 15 forks source link

FFmpeg not working #27

Closed Tomato6966 closed 1 year ago

Tomato6966 commented 1 year ago

player.node.send({ "op": "ffmpeg", "guildId": message.guildId, "args": ['aresample=48000,asetrate=48000*0.7,atempo=1.3,aresample=48000'] }) image

Audio just stucks.

Ubuntu 20

kernel: 5.19.5-051905-generic

node 18.9

ffmpeg-static and apt-get install ffmpeg both installed

PapiOphidian commented 1 year ago

what source was being used?

Tomato6966 commented 1 year ago

the latest release

PapiOphidian commented 1 year ago

I meant the track. Is it YouTube?

PapiOphidian commented 1 year ago

This may or may not be fixed in 1.4.0 I wasn't able to reproduce the issue, but I've been using the development version internally. If it doesn't lmk

PapiOphidian commented 1 year ago

If this hasn't been fixed, please provide more info, otherwise, this will be closed

freegamerskids commented 1 year ago

this also happens to me, but it says: (song) got stuck! Threshold surpassed: 10000 image

PapiOphidian commented 1 year ago

I have not been able to reproduce this issue. For testing purposes, I'd like to see if this has been fixed for you guys in 1.5.0

freegamerskids commented 1 year ago

I have not been able to reproduce this issue. For testing purposes, I'd like to see if this has been fixed for you guys in 1.5.0

This is still the issue. Haven't been fixed.

PapiOphidian commented 1 year ago

I only now realized this was for op ffmpeg

Peter-MJ-Parker commented 1 year ago

I wonder how many of these users were playing from heroku?? I personally don't use heroku as they share ip's between users and servers therefore complicating Discord rate limits and music bots.

PapiOphidian commented 1 year ago

OP ffmpeg has now been removed as ffmpeg is planned to not be used in the future and because I cannot conceivably resolve these issues due to the arbitrary nature of the op. Should you be trying to use it to emulate the functionality of lavalink filter ops, please open an issue or a PR or message me on Discord an ffmpeg arg format to get similar results to lavalink's filter op. Should you REALLY desire ffmpeg, Volcano's plugin system allows you to mutate the ffmpeg args Array that Volcano passes to the streamPipeline of each and every source that has one. https://github.com/AmandaDiscord/Volcano/blob/main/src/worker.ts#L129 This can be combined with the fact that plugins also have their own ws message handlers, but you will have to work around the fact that Volcano is threaded