Closed victorhsieh closed 3 years ago
This is only used in tests, so it should be pretty trivial to upgrade. Do you want to make a pull request for this?
The right solution isn't clear to me. There doesn't seem to be a seeding API exposed from XorShiftRng anymore. So I'd have to use rand_core::SeedableRng
. But that also breaks both indices.shuffle(&mut rng);
and rng.gen_range
since those API has changed.
I'm not familiar with rand*. Is rand_xorshift
necessary? Or maybe the way to use it has changed?
The only thing we care about is that the seed is the same every time the tests are run, to avoid non-determinism. We don't particularly care what RNG is used, as long as it can be seeded to give the same numbers on every run.
Sorry for the slow response. Finally had a chance to look at this again, and figured out the actual problem.
The crate currently depends on
rand_xorshift 0.2.0
. But it seems likeXorShiftRng::seed_from_u64
has been removed in 0.3.0. Here is what the build error looks like when I try to uprev rand_xorshift:It'd be great to migrate away from the deprecated API.