search

Amanieu / parking_lot

Compact and efficient synchronization primitives for Rust. Also provides an API for creating custom synchronization primitives.
Apache License 2.0
2.76k stars 217 forks source link

Migrate to `safer_owning_ref` #409

Open noamtashma opened 1 year ago

noamtashma commented 1 year ago

After the maintainer of owning_ref has been unresponsive for a long time, I published my fix of owning_ref known soundness issues as a new crate, safer_owning_ref.

Please migrate to safer_owning_ref.

bjorn3 commented 1 year ago

parking_lot doesn't use owning_ref itself. It only has an optional dependency to allow implementing the StableAddress trait of it for the mutex types in case the user wants to use owning_ref. Migrating would break everyone who uses owning_ref with parking_lot mutexes. Having both as optional dependencies would be a possibility though, but I personally don't think safer_owning_ref is nearly as popular for parking_lot to depend on it rather than the other way around. There are several owning_ref alternatives which are way more popular and still maintained like ouroboros and self_cell.

Disclaimer: I'm not a maintainer of this crate.

noamtashma commented 1 year ago

I see. makes sense