search

Amaroq7 / SPMod

SourcePawn Scripting Engine for Half-Life 1 based games
GNU General Public License v3.0
27 stars 12 forks source link

Visual studio project #62

Closed voed closed 4 years ago

voed commented 4 years ago

Meson has built-in VS project generator but its completely fucked up and needs a lot of fixes after generation. Why dont just create project once and add it to repository?

Amaroq7 commented 4 years ago

This could be done, the only concern I have is those files could go easily out of date, since not everyone uses visual studio for development and the project is still in early development, so I expect lots of changes happen in those files. Sure they could be edited by hand but there's no guarantee that they'll be working properly.

If there are people who use visual studio for building and are willing to keep an eye on those files whether they work as they should, I see no problem to add them.

voed commented 4 years ago

I can do that. But what about SPConfig file? Its generated by meson. When "commit sha" can be just replaced by static text(as long as its 3rd party user build), version is hardcoded in meson.build. Maybe we can create some version file?

Amaroq7 commented 4 years ago

Version and commit sha could be hardcoded in f.e. msvc20xx/SPConfig.hpp. I'd also add some define like SP_USE_MSVC_CUSTOM_VERSION to include appropriate SPConfig.hpp.