search

Amaroq7 / SPMod

SourcePawn Scripting Engine for Half-Life 1 based games
GNU General Public License v3.0
27 stars 12 forks source link

Added Visual studio solution #64

Closed voed closed 4 years ago

voed commented 4 years ago

Closes #62

Amaroq7 commented 4 years ago

Doesn't it need to be 

#if defined SP_USE_MSVC_CUSTOM_VERSION
    #include <msvc/SPConfig.hpp>
#else 
    #include <SPConfig.hpp>
#endif

in https://github.com/Amaroq7/SPMod/blob/b7a9b908410a76812b2a1b86104684d9c38b8da1/src/spmod.hpp#L114 ?

I'd also add msvc version to the folder name like msvc2017 or msvc2019 to indicate for what version project files were generated.

voed commented 4 years ago

@Amaroq7 i just added msvc as include folder, so it will be included without macros.

I'd also add msvc version to the folder name like msvc2017 or msvc2019 to indicate for what version project files were generated.

I can do it, but project files should be compatible with any VS version, so its unnecessary

Amaroq7 commented 4 years ago

@Amaroq7 i just added msvc as include folder, so it will be included without macros.

I'd also add msvc version to the folder name like msvc2017 or msvc2019 to indicate for what version project files were generated.

I can do it, but project files should be compatible with any VS version, so its unnecessary

I believe it's good to go then.