search

Amartus / yang2swagger

Yang to swagger generator
Eclipse Public License 1.0
32 stars 21 forks source link

Not showing range values in swagger #39

Open jdillard opened 4 years ago

jdillard commented 4 years ago

I converted swagger-generator/src/test/resources/simplest.yang, which has an integer with a range of 1 to 4096:

typedef myint1 {
    type int32 {
        range 1..4096;
    }
  }

Although, in the swagger it isn't generating the minimum and maximum values associated with the integer as shown here: https://swagger.io/docs/specification/data-models/data-types/#range.

If anyone has tips on where to look, I can try and submit a patch.

exgphe commented 2 years ago

I implemented this feature as well as other missing properties in my fork. It's located in class TypeConverter. My fork is not crafted enough to patch into this project though.

Do mind that minimum and maximum in swagger are not equivalent to YANG's range, since YANG supports multiple ranges for a type.

bartoszm commented 2 years ago

@exgphe can I have at your fork and cherry pick appropriate changes ?