Closed ihrasko closed 2 years ago
it looks OK, let me build + run it and check one additional aspect regarding RPC in/out and if there are no problems I will integrate that with the code base. thank you for the contribution
@ihrasko I built your changes and tried generating swagger - Two items I noticed there: 1) It's not generating paths for /config/ /operational/ 2) It's generating every leaf properties with "default": "" and "description": "" if it's not defined in yang, which is probably ok, but why to keep empty placeholders
Q: It's generating every leaf properties with "default": "" and "description": "" if it's not defined in yang, which is probably ok, but why to keep empty placeholders
A: Fixed.
Q: It's not generating paths for /config/ /operational/
A: It's because it's generating RFC8040 paths by default. It means you can see /data/
instead of config
or operational
.
To change this behaviour you have to set parameter path-format
to odl
.
I have fixed comments from @kasingal. @bartoszm do you have cycles to make review?
Thank you!
hey, I just came back from long vacation - will look at this PR today.
Hi, I have noticed that for some time integration tests were not triggered as part of the standard build. I have added them in the master branch and fixed failing tests (due to changes in how paths are interpreted).
I have rebased your PR and additional tests in *It
are failing. would you mind looking into that?
OK, I will check.
@bartoszm I will try to rebase this PR on master branch and solve remaining issues - next week or so :D