search

AmatCoder / mednaffe

A front-end (GUI) for mednafen emulator
GNU General Public License v3.0
429 stars 35 forks source link

art too high at start images attached to show #140

Closed ghost closed 2 years ago

ghost commented 2 years ago

So front end is great, However one small glitch im noticing with snaps/artwork, on initial open everything moves up to high, happens with fresh installs on any windows 10 machine. attaching two pics, bad is what happens and proper is expected behavior. Also Ide like to saty im not complaining just reporting what I notice in case you want to know. im already happy with my setup. bad proper

ghost commented 2 years ago

so if i take this config line [GUI] Dirs=C:\Users\James.UNIROPE\Desktop\A8\INCOMMING\no-tg16,false,true,.,C:\Users\James.UNIROPE\Desktop\A8\INCOMMING\mednafen\snaps,C:\Users\James.UNIROPE\Desktop\A8\INCOMMING\mednafen\artwork,508,422;

and delete the two positions as follows

[GUI] Dirs=C:\Users\James.UNIROPE\Desktop\A8\INCOMMING\no-tg16,false,true,.,C:\Users\James.UNIROPE\Desktop\A8\INCOMMING\mednafen\snaps,C:\Users\James.UNIROPE\Desktop\A8\INCOMMING\mednafen\artwork;

and write protect the config all behaves perfect but i get an error exiting because i write protected config.

ghost commented 2 years ago

so even with save positions turned off the following values change in config. can you add a flag to prevent the change?

[GUI] Dirs=C:\Users\James.UNIROPE\Desktop\A8\INCOMMING\no-tg16,false,true,.,C:\Users\James.UNIROPE\Desktop\A8\INCOMMING\mednafen\snaps,C:\Users\James.UNIROPE\Desktop\A8\INCOMMING\mednafen\artwork,508,422;

the 508 and 422 to always be 0 or always be locked

AmatCoder commented 2 years ago

I was able to reproduce this.

It seems to be a race condition between GtkPaned and GtkWindow. When mednaffe is launched, GTK set positions of paned then resize window (it should be the other way around).

ghost commented 2 years ago

I was able to reproduce this.

It seems to be a race condition between GtkPaned and GtkWindow. When mednaffe is launched, GTK set positions of paned then resize window (it should be the other way around).

my current temp fix is running with cfg as read only, rror on exit but runs flawless

AmatCoder commented 2 years ago

Fixed with commit 77c53bf

This race condition happened when state of GtkWindow was maximized, because:

[...] maximization is ultimately handled by the window manager and happens asynchronously to an application request [...]

(From GTK documentation)

ghost commented 2 years ago

So if I understand correctly when the window was maximized the code vs windows were both computing i guess? Will test your new dev build and report back. Thank you.

ghost commented 2 years ago

Works good now with the update you shared!!