Amateur-God / home-assistant-technitiumdns

This custom integration allows you to integrate TechnetiumDNS with Home Assistant, providing sensors for various DNS statistics.
GNU General Public License v3.0
13 stars 1 forks source link

Buttons and Switches aren't linked to the device #31

Closed cvroque closed 2 months ago

cvroque commented 2 months ago

Problem/Motivation

Buttons aren't showing up on the device page!

Expected behavior

All entities available on the device page

Actual behavior

The integration adds 1 device and 27 entities, but only 21 (the sensors) are linked to the device it creates. I believe the buttons also are lacking unique ids.

Steps to reproduce

I just configured the integration and checked the devices: image

Proposed changes

Thanks for the great integration! It doesn't stop the buttons from working, but make these harder to find.

Amateur-God commented 2 months ago

This is odd, can you see what entities you have? I'm unable to recreate this issue

image

cvroque commented 2 months ago

This is odd, can you see what entities you have? I'm unable to recreate this issue

The first 6 on this screenshot are the ones not showing: image And here's the device page: image

Thanks again!

Amateur-God commented 2 months ago

can you try removing your DNS server and updating to the latest version of the integration and then reconfiguring your DNS server

cvroque commented 2 months ago

Despite the screenshot showing 2,2.1, I'm actually on the latest: image I tried removing the integration, restarting and adding again with the same results. Here's the other version details: image

I enabled debug logging for technitiumdns and attached the results. DEBUG.LOG I believe this may be related: image

Amateur-God commented 2 months ago

Ive just updated my HASOS and replicated the issue, seems to be something caused by the new update, ive pushed a beta release to attempt to fix this, feel free to load that, i usually move them from beta to live after ive tested it for a week or 2

https://github.com/Amateur-God/home-assistant-technitiumdns/releases/tag/v2.2.3-beta.1

cvroque commented 2 months ago

Ive just updated my HASOS and replicated the issue, seems to be something caused by the new update, ive pushed a beta release to attempt to fix this, feel free to load that, i usually move them from beta to live after ive tested it for a week or 2

https://github.com/Amateur-God/home-assistant-technitiumdns/releases/tag/v2.2.3-beta.1

Thanks, I just tested it and everything is in place, except the switch to enable/disable adblocking which is missing entirely.

image

Amateur-God commented 2 months ago

Ive just updated my HASOS and replicated the issue, seems to be something caused by the new update, ive pushed a beta release to attempt to fix this, feel free to load that, i usually move them from beta to live after ive tested it for a week or 2 https://github.com/Amateur-God/home-assistant-technitiumdns/releases/tag/v2.2.3-beta.1

Thanks, I just tested it and everything is in place, except the switch to enable/disable adblocking which is missing entirely.

image

Yeah ive just realised that i mistakingly put duration as a UniqueID attribute for switches like i did with buttons completely forgetting they dont have a duration attribute

should be fixed in

https://github.com/Amateur-God/home-assistant-technitiumdns/releases/tag/v2.2.3-Beta.2|

sorry about that ive been coding all day so a little burnt out

cvroque commented 2 months ago

It's perfect now, there's nothing to apologize for, thanks for the great integration and fast replies!

Amateur-God commented 2 months ago

Just reopening this while the fix is in beta for anyone else who has the issue and as a reminder to me to move beta to live after testing thoroughly

Amateur-God commented 2 months ago

you may need to re-add the switches as i fixed a typo in entity names