AmauriC / tarteaucitron.js

RGPD friendly cookie manager
https://tarteaucitron.io/
MIT License
916 stars 369 forks source link

feat(matomocloud): Improve cookieless tracking fallback #1249

Open ambroisemaupate opened 3 months ago

ambroisemaupate commented 3 months ago

This PR should not break compatibility with existing matomocloud service. These features are optional and only triggered when defining parameters above.

stale[bot] commented 3 months ago

This issue has been automatically marked as inactive because it has not had activity for 20 days. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

AmauriC commented 2 months ago

Hi,

Thanks for your contribution and sorry for the delay to reply.

On the pro version, this is not possible to set as undefined a string option, so for example tarteaucitron.user.matomoCustomCookieDomain and tarteaucitron.user.matomoFallbackId will be empty and it will break the logic.

Can you change the check from undefined to empty string?

Thanks!

ambroisemaupate commented 2 months ago

I've kept tests against undefined and added tests against empty string as requested.