search

AmazaspShumik / sklearn-bayes

Python package for Bayesian Machine Learning with scikit-learn API
MIT License
513 stars 118 forks source link

danger place fixes #17

Closed ferrine closed 8 years ago

ferrine commented 8 years ago

There were some bad code examples that could led to unexpected behaviour. One most frequent was mutable as default value for a function. I also found misprint at line 529(9c667908f5e7c81e637f5dc40a537389cf0fd3bc). Some imperfections are still left, like inheritance complexity, I mean _init_params method. I think it could be refactored to look and used more pretty.

AmazaspShumik commented 8 years ago

Thanks,

You are right about init_params, there are couple of other places it needs to be fixed (VBGMMARD for instance). I will work on that. I am rewriting forward - backward part of HMM in Cython to improve speed in for loop, should have it ready by the end of next week.