Incorrect log message when login fails

Amazebot / bbot

An adaptable conversation engine for building bespoke bots.

MIT License

55 stars 2 forks source link

Incorrect log message when login fails #114

Closed exhuma closed 4 years ago

exhuma commented 5 years ago

When using the wrong password the log messages say:

info:   [login] Error:User not found [403]
error:  [adapter] startup failed: User not found [403]

This is incorrect on two levels:

The HTTP status code should be 401 instead of 403 (although this probably comes from the back-end?)
The message that the user was not found is misleading.

timkinnane commented 5 years ago

Yeah the error message and code is just relayed from the backend. Are you connecting to a Rocket.Chat instance? Do you have a username and pass configured for a user with the bot role?

exhuma commented 5 years ago

Yeah. I managed to log-in. I mainly created this issue about the message itself. You can close the issue if you want as you're only relaying from the BE.