Amazebot / bbot

An adaptable conversation engine for building bespoke bots.
MIT License
55 stars 2 forks source link

Remove event emits from thought processes #83

Closed timkinnane closed 6 years ago

timkinnane commented 6 years ago

Emitting was a simple way to test processes were executing early on but then thought changed from being a singleton set of processes to methods of an instance of Thought, to allow multiple concurrent thought processes. I think events are probably not good for performance and an unnecessary utility, with middleware and promise returns available.

Removing events would require a fair bit of refactoring in thoughts.spec.ts, to use stubs and spies to confirm process execution instead.