chindris
commented
3 months ago Isn't
+=supposed to be a shorthand for array merge 😅 ? Thank you for nothing PHP!Nevertheless, thanks @chindris
@pmelab they are similar, but not exactly the same...They do merge arrays, but in a different way, here is an excerpt from the array_merge docs ( https://www.php.net/manual/en/function.array-merge.php ):
If the input arrays have the same string keys, then the later value for that key will overwrite the previous one.
and then in one of the examples bellow, it states:
If you want to append array elements from the second array to the first array while not overwriting the elements from the first array and not re-indexing, use the + array union operator.
So by using the union operator ("+"), the elements from the first array are not overwritten.
Package(s) involved
silverback_gatsby
Description of changes
Once the GraphQL Build entity is saved at /admin/config/graphql/servers/build/silverback_gatsby for example (let's say the Notification user gets updated), a second update operation is not possible because the buildEntity() method of the Build entity class uses "+" to append data into the configuration entity. But the "+" operation would not overwrite existing data. One solution (which has been implemented) is to use array_merge. Another one would be to use the "+", but in a different way, something like:
$entity->schema_configuration[$entity->schema] = $form_state->getValue('schema_configuration')[$entity->schema] + $entity->schema_configuration[$entity->schema]Related Issue(s)
GraphQL Server Build entities cannot be updated
How has this been tested?
Locally, manually.