AmazingAmpharos / OoT-Randomizer

A randomizer for Ocarina of Time.
Other
296 stars 365 forks source link

Where is the option to having fairy rewards only shuffled between the fountains and not globally (in the dev build)? #156

Open Kongolan opened 6 years ago

Kongolan commented 6 years ago

Why can't i set that i need to visit the fairy fountains, to obtain these strong rewards (but on random, where which reward is). I don't want to find magic in a random chest somewhere. Older versions of the randomizer had this, so why not a flag for it??

flagrama commented 6 years ago

That, like grotto chests and free-standing heart pieces, were only in existence due to technical issues and were never meant to be a part of the final randomizer. That is why there is no option for these three v1.0 behaviours.

phixtyseven commented 6 years ago

I would agree that it was kind of neat knowing all fountains contain magic rewards, but it seems like a niche preference. I'd like to try to add support for specialized configurations in the future but I don't think we're quite there just yet.

Kongolan commented 6 years ago

If you can clarify for me, what exactly was the change, which added fountains the general item pool, then i might can look for it myself and create a pull request for it. I didn't look much into the code, but when the fountain thing got changed and maybe it's possible to split the arrays.

phixtyseven commented 6 years ago

Well, after a hasty peek through the commits...

There may be more to it, but at least it's a start

Kongolan commented 6 years ago

It seems like only the entrances were switched, while this can't not be reverted back and is not the best way to do it. The best would be to add a own item pool for the fountain rewards and then if the flag is true apply the items rewards from it (which the 2nd commit changed so fairy can apply items) and if it's false it just falls back to default. Not that hard to do actually, but looking the first time at the code, i'm not fully aware on how the items are replaced.

But thanks for the help, i was hoping the fix would be much easier for me, but as long i'm not aware how often "alwaysitems" is used and how exactly it is implemented, it will be hard for me to fix.

So I must wait for the release, thanks for the help so far!