AmazingAmpharos / OoT-Randomizer

A randomizer for Ocarina of Time.
Other
296 stars 365 forks source link

Exclude Stone of Agony from hints if it is needed to get hints #225

Closed Mego closed 5 years ago

Mego commented 5 years ago

If Stone of Agony is needed to get hints from gossip stones, then they should not tell you where it is (since you must already have it to get the hint in the first place). This adds the Stone of Agony as a hint exclusion in that case, removing a useless hint.

rlbond86 commented 5 years ago

If the Stone of Agony is not required to get hints, it should also be excluded, since it doesn't do anything.

Mego commented 5 years ago

If the Stone of Agony is not required to get hints, it should also be excluded, since it doesn't do anything.

Having the location be a hint is helpful for 100% runs in that case.

flagrama commented 5 years ago

You should know that https://github.com/TestRunnerSRL/OoT-Randomizer is currently the main development repository for OoT-Randomizer.

flagrama commented 5 years ago

Also it would appear you have appended an item to a list that checks for excluded locations instead. Are you sure this code does what you want it to do?