search

AmazingDreams / vue-matomo

Vue plugin for Matomo Analytics
MIT License
282 stars 61 forks source link

Url contains // when mode is set to history #39

Closed jordan-boyer closed 5 years ago

jordan-boyer commented 5 years ago

This issues appear after you fix issue #37

example : When base url is set to bar and route is foo, vue matomo will return bar//toto
quick fix: remove last / in routerBase = /${routerBase}/ and add / before # in const maybeHash = options.router.mode === 'hash' ? '#' : ''

AmazingDreams commented 5 years ago

Thanks. Didn't think that through entirely. Fixed!

jhfyang commented 5 years ago

This issue is still ongoing for me with version vue-matomo@3.12.0-5

AmazingDreams commented 5 years ago

Will investigate

AmazingDreams commented 5 years ago

Should be fixed in v3.13.0-0 thanks to @pdl through #45