handle TMS - Githubissues

AmazingDreams / vue-matomo

Vue plugin for Matomo Analytics

MIT License

278 stars 61 forks source link

handle TMS #52

Closed RonnyTite closed 4 years ago

RonnyTite commented 4 years ago

In case of TMS, we load a first container_XXX.js which triggers aynchronously the loading of the standard Piwik.js.

this was throwing an error in initMatomo when trying to assign window.Piwik const Matomo = window.Piwik.getAsyncTracker()

the catch will follow with another error of src of target undefined (following PR#48) Fix created in PR#51

This will avoid the error throwed in initMatomo when window.Piwik is undefined

AmazingDreams commented 4 years ago

Can you provide some kind of steps for a test setup? It looks good, but I'm just wondering how it works with the TMS

RonnyTite commented 4 years ago

here : https://developer.matomo.org/guides/tagmanager/embedding

If you're already using matomo you can set you siteId, your trackerUrl,

and set the TMS script as trackerFileName (container_<something>.js) .

It should be testable with this.

RonnyTite commented 4 years ago

@AmazingDreams were you able to test ?

AmazingDreams commented 4 years ago

Sorry it took me so long, thanks for your contribution