search

AmazingDreams / vue-matomo

Vue plugin for Matomo Analytics
MIT License
282 stars 61 forks source link

Parametrize name of 'piwik.js' file and 'piwik.php' #53

Closed gelmiro closed 4 years ago

gelmiro commented 4 years ago

Hi, I have problem with downloading of piwik.js and 'piwik.php' file. On my server this file have different name (extension to be precise) and plugin fail when try to download it. Could you give possibility to inject own name (with extension) for this file for download? For example file on my server have name foo.bar

AmazingDreams commented 4 years ago

There is an option that may be what you're after called trackerFileName, would this work for your use case?

Vue.use(VueMatomo, { // Changes the default .js and .php endpoint's filename // Default: 'matomo' trackerFileName: 'matomo',

gelmiro notifications@github.com schreef op 17 februari 2020 07:42:30 CET:

Hi, I have problem with downloading of piwik.js file. On my server this file have different name (extension to be precise) and plugin fail when try to download it. Could you give possibility to inject own name (with extension) for this file for download? For example file on my server have name foo.bar

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/AmazingDreams/vue-matomo/issues/53

AmazingDreams commented 4 years ago

Ah, i see you're specifically referring to the extension. That's currently not possible. Do you think you could create a PR? I can do it but I don't have a lot of time atm

gelmiro notifications@github.com schreef op 17 februari 2020 07:42:30 CET:

Hi, I have problem with downloading of piwik.js file. On my server this file have different name (extension to be precise) and plugin fail when try to download it. Could you give possibility to inject own name (with extension) for this file for download? For example file on my server have name foo.bar

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/AmazingDreams/vue-matomo/issues/53

gelmiro commented 4 years ago

Ok, I will try to prepare PR

AmazingDreams commented 4 years ago

Thanks! I'd suggest looking at the trackerUrl option and how it's implemented. Something like trackerScriptUrl would be a good name. Maybe 2 LOC and some documentation in README

I'll have some time tomorrow to do the merge and publish a new version

gelmiro notifications@github.com schreef op 17 februari 2020 08:04:19 CET:

Ok, I will try to prepare PR

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/AmazingDreams/vue-matomo/issues/53#issuecomment-586846368