search

AmazingDreams / vue-matomo

Vue plugin for Matomo Analytics
MIT License
274 stars 61 forks source link

In my vue project, "action_name" is not change dynamic, so i see the source code and find the problem! #58

Closed SeanBurt closed 4 years ago

SeanBurt commented 4 years ago

image image

AmazingDreams commented 4 years ago

I think this would be a matter of preference, if the title is omitted the URL itself will be used as a title iirc. I personally didn't like the behavior of using a name pulled from the router. I'll play around with some options

Lie notifications@github.com schreef op 30 maart 2020 10:43:02 CEST:

image image

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/AmazingDreams/vue-matomo/issues/58

SeanBurt commented 4 years ago

I think this would be a matter of preference, if the title is omitted the URL itself will be used as a title iirc. I personally didn't like the behavior of using a name pulled from the router. I'll play around with some options Lie notifications@github.com schreef op 30 maart 2020 10:43:02 CEST: … image image -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #58

In spa(single page application), title is dynamic when change the router, when you set options once, the action_name is also can't change dynamically, so you must set action_name with router meta in router hook.

fbonin commented 4 years ago

I have a PR that uses the title in the router if specified but it is based on the PR on this issue

https://github.com/AmazingDreams/vue-matomo/issues/56

I can create the PR once approved.

SeanBurt commented 4 years ago

I have a PR that uses the title in the router if specified but it is based on the PR on this issue

56

I can create the PR once approved.

Hi, this pr can't solve my issue, in spa(single page application), title is dynamic when change the router. When you set options once, the action_name is also can't change dynamically, so you must set action_name with router meta in router hook.

AmazingDreams commented 4 years ago

Thanks!