search

AmazingDreams / vue-matomo

Vue plugin for Matomo Analytics
MIT License
278 stars 61 forks source link

add compatibility for Vue 3 #68

Closed jordan-boyer closed 4 years ago

jordan-boyer commented 4 years ago

Description

This PR add compatibility for the new version of Vue (3)

Proof of concept

Link for Vue 2 Link for Vue 3

AmazingDreams commented 4 years ago

This looks good. I'll have to double check this as there's some fundamental changes that could break stuff.

AmazingDreams commented 4 years ago

I made some additional changes to improve tracking, as nextTick was used to ensure that the window.location got updated before the tracking request was sent.

https://github.com/AmazingDreams/vue-matomo/tree/jordan-boyer-chore/compatibility-with-vue-2-and-3

I just need to set up a test / demo with vue 3

jordan-boyer commented 4 years ago

Do you want me to set up a demo like you did with Vue 2 ?

AmazingDreams commented 4 years ago

I have already set up a demo on the linked branch, I think it works properly but I haven't gotten around to testing various router settings like the base path in vue 3