KDlamini
commented
1 year ago Status: Invalid 🔴
Hi @Amazinggracee, @jkanyi-web 🙋♀️,
While you made a great effort in this project, I can't go ahead and review your code.
Invalid Code Review Request
You have submitted a project, that does not gollow the proper GitHub flow. The pull request you should submit should be opened from the dev branch into the main branch and include all the changes from all your feature branches.
- Please make sure to remove the live demo link if the project is not deployed. You should not have any broken links in your README.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers 🥂 and Happy coding!!! 👯 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me @KDlamini in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.
Project requirements.
[ ] APIs
First, you need to find an API so you can base the development of the webapp around it. The API should allow you to:
Get a list of items with a unique item id (or generate the unique id).
For a given item, get detailed information about it.
You will use our [Involvement API]
[ ] Interfaces
You should build these interfaces:
You should follow the layout of the wireframes provided.
Home page When the page loads, the webapp retrieves data from: The selected API and shows the list of items on screen. The Involvement API to show the item likes. Remember that your page should make only 2 requests: One to the base API. And one to the Involvement API. When the user clicks on the Like button of an item, the interaction is recorded in the Involvement API and the screen is updated. When the user clicks on the "Comments" button, the Comments popup appears. When the user clicks on the "Reservations" button, the Reservations popup appears (only for the groups of 3 students). Home page header and navigation similar to the given mockup. Home page footer similar to the given mockup. Comments popup When the popup loads, the webapp retrieves data from: The selected API and shows details about the selected item. The Involvement API to show the item comments. When the user clicks on the "Comment" button, the data is recorded in the Involvement API and the screen is updated. Reservations popup (only for the groups of 3 students) When the popup loads, the webapp retrieves data from: The selected API and shows details about the selected item. The Involvement API to show the item reservations. When the user clicks on the "Reserve" button, the data is recorded in the Involvement API and the screen is updated. Counters We have counters in all the interfaces that show:
The number of items (home). The number of comments (comments popup). The number of reservations (reservations popup) - only for the groups of 3 students. Even if the API gives you these numbers, you will create a specific function to calculate these numbers in each page. These count functions need to be covered with unit tests using Jest.
Technical set up
Set up the repository on GitHub and use Gitflow. Set up webpack. Set up a JavaScript testing library (Jest).