search

Amazinite / Shields-Up

The (in)famous Shields Up plugin for Endless Sky!
21 stars 9 forks source link

Were you not removing the regional pirates? #3

Closed Amazinite closed 8 years ago

Amazinite commented 8 years ago

I thought the regional pirates were suppose to be removed as to keep compatibility with other mods, or at least only be used during missions that involve them. If so, I can go through and change the relevant information to remove them from fleets and such.

Disiuze commented 8 years ago

TBH, they should be removed.

FriendlyNeighbour commented 8 years ago

Yeah, they should be removed. Might require some reworking with the fleets, I don't believe the vanilla pirate fleets have a file in SU that adds our modded ships. (They possibly do, I'd have to check.)

Amazinite commented 8 years ago

Speaking of fleets, some merchant fleets have pirate ships, which seems odd to me. The one I've seen is the Pirated Frigate. And if the Pirated Frigate is in a pirate fleet, it should only be in the northern pirate fleets given their proximity to the Navy.

FriendlyNeighbour commented 8 years ago

Hm, that's strange (regarding the merchants). We'd have to fix that up, and if we're getting rid of the different pirate factions than the pirated frigate would still be distributed to all the pirates :/

Speaking of which, this reminded me of a couple system overlapping issues with some of the official mod systems added to the claim a piece of the map thing that MZ set up. I can get to fixing that. (it was the north-west and west systems that had the issue.)

Amazinite commented 8 years ago

and if we're getting rid of the different pirate factions than the pirated frigate would still be distributed to all the pirates :/

No, because there are still regional pirate fleets in vanilla, just not regional pirate factions.

Amazinite commented 8 years ago

fae8d0f Unless I missed something outside of the SU folder, there was only one regional pirate fleet left xD Should I remove the governments as well?

FriendlyNeighbour commented 8 years ago

Might as well. xD

Amazinite commented 8 years ago

40889a5