search

Amazinite / Shields-Up

The (in)famous Shields Up plugin for Endless Sky!
21 stars 9 forks source link

some typos in map.txt #48

Closed Phil-Morley closed 8 years ago

Phil-Morley commented 8 years ago

Fixed 5 typos in map.txt of 004_Shields_up/data

(and hopefully worked out how to use github :)

Phil-Morley commented 8 years ago

I changed the pirate frigate and spearhead to be medium warships and uploaded to my fork, seems that it has included these changes with this PR?

Amazinite commented 8 years ago

Instead of updating the existing files, you uploaded copies of the original files with your changes...

Phil-Morley commented 8 years ago

sorry that is what I thought I was supposed to do :) will try again :)

Phil-Morley commented 8 years ago

ok, fixed some typos and spelling errors in my fork and pull request. (deleted the uploaded files, which is also now showing here, just to really highlight that I am a noob on github :)

Amazinite commented 8 years ago

All the "refueling" -> "refuelling" changes are wrong. It's proper the way it was. Other than that, everything looks good.

Phil-Morley commented 8 years ago

American spelling? when I went back to change the file I couldn't remember the 5 changes I'd made so I dropped the text in word for the spell checker. Resisted putting the 'u's in :D

FriendlyNeighbour commented 8 years ago

I personally use the English spelling, so using a "u" is what I'd do

Amazinite commented 8 years ago

Yeah, I'm fine with extra u's.

FriendlyNeighbour commented 8 years ago

You cant spell Shields-Up without u :P