search

Amazinite / Shields-Up

The (in)famous Shields Up plugin for Endless Sky!
21 stars 9 forks source link

paul mission chain #74

Closed Phil-Morley closed 7 years ago

Phil-Morley commented 7 years ago

the paul mission chain requires a light freighter to continue from splashdown. There is no mention of this and if you do not have a light freighter the mission chain ends without knowing why. Needs to either mention that light freighter is needed or remove has light freighter from mission "Ext Intro [Cargo 1]" in Paul mission chain.txt

FriendlyNeighbour commented 7 years ago

One sec, checking it out

FriendlyNeighbour commented 7 years ago

I think you may be a bit confused on how that chain is set up. Cargo 1 requires a light freighter, and there are two other chains depending on 2hat type of ship you have. Although looking back at it, we could probably have an "or" command in some, since when the player finds the chain, they may have a heavy freighter.

Phil-Morley commented 7 years ago

ok, I took him to splashdown and it said go to the spaceport to continue. Went to spaceport and nothing happens, was left wondering where he was. Left and come back trying to find him etc. Ended up looking at the mission chain to try and work out where he went :) removed the requirement for light freighter and we are going again :)

FriendlyNeighbour commented 7 years ago

What ship class were you in

Phil-Morley commented 7 years ago

heavy warship

FriendlyNeighbour commented 7 years ago

Ok, so the problrm isn't that it requires a loght freighter, it's that the interceptor mission needs to have something like: requires interceptor or heavy warship

Same with medium warships, etc. The Paul mission chain had 3 different trees, one for if you picked a cargo ship, another for transport, another for interceptor. We just need to add the other ships classes in for their respective chains. Combat based classes need to be added as requirements for the interceptor 1 chain. Get what I'm saying?

In the code, scroll down past the cargo chain and you'll see the other chains

Phil-Morley commented 7 years ago

yep, cool

FriendlyNeighbour commented 7 years ago

Are we sure the way it's written now works? We have multiple ship types listed. Do we not need an "or" line?

Like: requires interceptor or heavy warship? And we also need to add the other ship classes to the cargo chain, since right now we only have light freighters set up for it

Amazinite commented 7 years ago

Going to fix it.

FriendlyNeighbour commented 7 years ago

Thank you, I'd love to help as well but I'm currently not at home :/

On Dec 26, 2016 1:58 PM, "Amazinite" notifications@github.com wrote:

Going to fix it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Amazinite/Shields-Up/issues/74#issuecomment-269234746, or mute the thread https://github.com/notifications/unsubscribe-auth/AQfAYNkkDFRJ6xMd5Us3V8P6hzSyfz0Iks5rMA5OgaJpZM4LVj8v .

Amazinite commented 7 years ago

fce22eb Phil had it right, he just missed the heavy freighter part.

Amazinite commented 7 years ago

Keeping open till we update.

FriendlyNeighbour commented 7 years ago

Okay, sweet. Just because I'm curious, do you know why that doesn't require someone seperating the requirements? Because the way it's written now seems like it would require you to have all of thosetypes of ships.

On Dec 26, 2016 2:03 PM, "Amazinite" notifications@github.com wrote:

Keeping open till we update.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Amazinite/Shields-Up/issues/74#issuecomment-269235026, or mute the thread https://github.com/notifications/unsubscribe-auth/AQfAYKJVMZ4hDC0hT6MvXzjXI9C5uDqkks5rMA9zgaJpZM4LVj8v .

Amazinite commented 7 years ago

MZ is weird, It's just how the syntax is. While it looks like you would need all of those, it actually reads like "interceptor or light warship or medium warship or heavy warship."

FriendlyNeighbour commented 7 years ago

Ah. Thanks.

On Dec 26, 2016 2:42 PM, "Amazinite" notifications@github.com wrote:

MZ is weird, It's just how the syntax is. While it looks like you would need all of those, it actually reads like "interceptor or light warship or medium warship or heavy warship."

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Amazinite/Shields-Up/issues/74#issuecomment-269237352, or mute the thread https://github.com/notifications/unsubscribe-auth/AQfAYIQ0TLBNs8MlbWLOXZNVJZ-axrRrks5rMBi8gaJpZM4LVj8v .