search

Amazon-Vine-Explorer / AmazonVineExplorer

Makes the Amazon Vine Website evan a bit better
MIT License
16 stars 8 forks source link

Initial implementation of multi-language support #27

Closed numericOverflow closed 2 months ago

numericOverflow commented 3 months ago

This is a bit hacky, and it's my first TamperMonkey/Greasemonkey contribution, but here you go. I won't even dare to claim that I'm any good at coding in javascript, but I can pretend well enough.

I don't know how to speak German, so I wanted to replace the various German strings with English. That seemed extremely short sighted so I added a very unsophisticated translation feature to your awesome tool.

FYI - The language is currently hard-coded in the globals.js file, so it would be far better to either : 1) auto-detect based on amazon site or something 2) add another option in your settings tab to allow the user to choose their display language.

Apologies for the unrefined implementation, but didn't want to waste a bunch of time adding a setting if you guys didn't want to use any of my code.

numericOverflow commented 3 months ago

FYI - this is the replacement PR from #25 I closed, I cleaned out a couple junk commits that were not needed and created this new PR as a replacement.

Christof121 commented 2 months ago

This Function is in early Beta stage. Branch in: https://github.com/Amazon-Vine-Explorer/AmazonVineExplorer/tree/Translation

Unfortunately, we cannot adopt the code in this way, but we have used a very similar method. Thanks for the effort, though.