AmazonAppDev / react-native-multi-tv-app-sample

πŸ“ΊπŸš€ React Native TV app sample for Android TV, Fire TV, tvOS, and web. Features customizable drawer navigation πŸ—‚οΈ, content grid πŸ–ΌοΈ, hero header πŸ¦Έβ€β™‚οΈ, and video player πŸŽ₯. Built with Expo. Perfect starter for cross-platform TV app development! 🌟
MIT No Attribution
99 stars 16 forks source link

Implement pre commit hooks #17

Closed Neha closed 1 week ago

Neha commented 1 month ago

Is your feature request related to a problem? Please describe. Add pre commit hooks. It help catch issues like linting errors, unformatted code, or failing tests before code is committed to the repository.

  1. Linting: Ensure that code follows the defined linting rules.
  2. Formatting: Automatically format code using tools like Prettier.
  3. Unit Tests (when we will have) : Run unit tests to ensure no breaking changes are committed.
  4. Type Checking (Optional): Add type checking if using TypeScript or similar tools.
  5. Git Commit Message Formatting (Optional): Enforce a standardized format for commit messages, e.g., following Conventional Commits.

Describe the solution you'd like

  1. on PR raise, pre commit hook should run and throw the errors on failing

  2. Code cannot be committed if linting, formatting, or tests fail.

Describe alternatives you've considered NA

Additional context NA

Neha commented 1 month ago

@giolaq I will take this

Neha commented 3 weeks ago

this issue has dependency on #14. If there is no response on #14 , I can do both together. lmk @giolaq