search

Amber-MD / pytraj

Python interface of cpptraj
https://amber-md.github.io/pytraj
170 stars 38 forks source link

Fix randomizeions test #1635

Closed drroe closed 1 year ago

drroe commented 1 year ago

Related to https://github.com/Amber-MD/pytraj/issues/1633#issue-1748483447

This is a work in progress to try and figure out why the randomize ions test for pytraj fails on CI but passes locally.

hainm commented 1 year ago

@drroe How are you going to test this? we don't run pytraj CI on Jenkins. So we need to merge your change to master, then trigger a dummy PR in cpptraj to trigger Jenkins run there.

drroe commented 1 year ago

So this was to ensure that the randomize_ions test was being run (by removing all the --ignore flags except the parallel_pmap one). Turns out I was just missing the output previously, so I will likely delete this PR soon. I think the real solution may be to disable the Jenkins test and just test pytraj directly on the cpptraj GitHub repo via actions.

hainm commented 1 year ago

Yeah, I agree with your plan.

drroe commented 1 year ago

Superseded by https://github.com/Amber-MD/cpptraj/pull/1035