Amber-MD / pytraj

Python interface of cpptraj
https://amber-md.github.io/pytraj
172 stars 38 forks source link

Chain ID is now a string as of cpptraj version 6.27.0 #1656

Closed drroe closed 5 months ago

drroe commented 5 months ago

Chain ID is now a string in the Residue class to accommodate multi-character residue IDs, as well as better support segment IDs in CHARMM PSF files. See https://github.com/Amber-MD/cpptraj/pull/1086

drroe commented 5 months ago

@hainm I'm going to merge this since the CI passed and pytraj will not build without it, hope you don't mind.

hainm commented 5 months ago

Hi Dan

I don’t mind at all.

Hai

On Fri, Jun 14, 2024 at 3:15 PM Daniel R. Roe @.***> wrote:

@hainm https://github.com/hainm I'm going to merge this since the CI passed and pytraj will not build without it, hope you don't mind.

— Reply to this email directly, view it on GitHub https://github.com/Amber-MD/pytraj/pull/1656#issuecomment-2168613604, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABB645L7GF3JECAEVAQ5KI3ZHM6LNAVCNFSM6AAAAABJK2QOHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRYGYYTGNRQGQ . You are receiving this because you were mentioned.Message ID: @.***>