search

AmbireTech / adex-platform

AdEx Platform UI
https://platform.adex.network
GNU General Public License v3.0
58 stars 19 forks source link

ENS (reverse registrar) for displaying addresses #114

Closed Ivshti closed 4 years ago

Ivshti commented 5 years ago

Challenge description:

if an address is associated with an ENS name, show that, rather than the address itself.

See https://docs.ens.domains/contract-api-reference/reverseregistrar

This way we can show stuff like "adex-recovery.ens" rather than "0x...

This can be achieved by creating a address component that will automatically look it up on the reverse registrar.

Submission requirements:

Judging criteria:

Submission deadline:

August 19

Bounty:

250 DAI

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 250.0 DAI (250.0 USD @ $1.0/DAI) attached to it as part of the AdExNetwork fund.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 1 week from now. Please review their action plans below:

1) iamonuwa has started work.

Committed to getting this ready. I understand the requirements very well. This is a clean one. 2) x5engine has started work.

PR with no side effects and design free that pulls the ens name for an eth address and can be used anywhere in the app!

Learn more on the Gitcoin Issue Details page.

michaelcohen716 commented 5 years ago

hi @Ivshti - the AdEx Node and AdEx view links on the AdEx Dapp repo readme are broken. Can you direct me to the proper repos?

x5engine commented 5 years ago

should we add an API dependency or it should have none?? for the bounties

Ivshti commented 5 years ago

In general it's OK to add dependencies, but an API dependency sounds unnecessary given that the same data can be retrieved via ethers.js whichis already a dep

On Mon, 29 Jul 2019 at 18:35, X5 Engine notifications@github.com wrote:

should we add an API dependency or it should have none?? for the bounties

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AdExNetwork/adex-dapp/issues/114?email_source=notifications&email_token=AAJQTDI3VUUWSI4ASDWMNT3QB4E5RA5CNFSM4H7QM7W2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3BDEQY#issuecomment-516043331, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJQTDPGLOEVAB7JZTMYI7TQB4E5RANCNFSM4H7QM7WQ .

--

[image: photo] Ivo Georgiev Founder & CEO, Stremio

https://www.stremio.com http://www.stremio.com

GPG: AC692BE9EB6E024B5C58A8EAC1E94996BC56BACE http://www.stremio.com http://www.facebook.com/stremio/ http://twitter.com/stremio http://www.instagram.com/stremioofficial/ http://www.reddit.com/r/Stremio/ http://blog.stremio.com/

https://play.google.com/store/apps/details?id=com.stremio.beta https://itunes.apple.com/us/app/stremio/id987232010?mt=8

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 250.0 DAI (250.0 USD @ $1.0/DAI) has been submitted by:

  1. @iamonuwa
  2. @x5engine

@Ivshti please take a look at the submitted work:

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 250.0 DAI (250.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @x5engine.