search

AmbireTech / adex-platform

AdEx Platform UI
https://platform.adex.network
GNU General Public License v3.0
58 stars 19 forks source link

When session is stored then every button redirects to the platform side choosing view #194

Closed TRtomasz closed 5 years ago

TRtomasz commented 5 years ago

Describe the bug When we open https://platform.adex.network/#/ and user session is stored in saved. Then clicking on any of the buttons redirects to the side choosing view(advertiser/publisher). I have checked it only with grant account.

To Reproduce Steps to reproduce the behavior:

  1. Go to adex platform, log in using grant account
  2. Close webpage
  3. Go to the adex platform, click any button: metamask, trezor, create grant account
  4. Instead of possibility to create/login using different account you are redirected to the side choosing view again

Expected behavior

  1. When user session is stored and he goes to the adex platform mainpage he should be redirected to the side choosing view OR
  2. When user session is stored and we don't want to redirect him to side the choosing view immediately: Clicking on "Login Grant Account" should redirect to the side choosing view Clicking on any other button should let user to log in using new account. Perhaps there could be a warning message about another account being logged in.

Screenshots image

Desktop (please complete the following information): Windows 10 Firefox 69.0.9

rori4 commented 5 years ago

Concerning this issue as I am testing this with metamask, whenever your session is stored but you are logged out of metamask you will be able to still login, which shouldn't be the case.

ivopaunov commented 5 years ago

I know about that issue, I have idea for quick fix but it might not work.

On Thu, Oct 24, 2019, 12:53 Rangel Stoilov notifications@github.com wrote:

Concerning this issue as I am testing this with metamask, whenever your session is stored but you are logged out of metamask you will be able to still login, which shouldn't be the case.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/AdExNetwork/adex-platform/issues/194?email_source=notifications&email_token=ACPQSWT542YMUG3D3UIDF7LQQFWCJA5CNFSM4JEQI4F2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECEOG7Y#issuecomment-545842047, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPQSWRLBNQJKGSPWBFEC73QQFWCJANCNFSM4JEQI4FQ .