AmbireTech / adex-platform

AdEx Platform UI
https://platform.adex.network
GNU General Public License v3.0
58 stars 19 forks source link

Change UTM links when name of ad unit is changed #223

Closed dmngdsm closed 5 years ago

dmngdsm commented 5 years ago

Is your feature request related to a problem? Please describe. If a user wants to change ad unit name for some reason, but is already using UTM data for analytics with the old name, the UTM link should also change. Otherwise renaming Ad Units is close to meaningless.

Describe the solution you'd like Possible solution: Just change UTM link when ad unit name is changed.

Describe alternatives you've considered Alternative: "Create New From" button that copies an ad unit as new one, but with unsaved targeting and name, so that you can create an ad unit with a new name but no need to upload creative again. I actually like this solution even better.

Additional context /

dmngdsm commented 5 years ago

@rori4 just showed me the "Cloning" feature which is 100% my alternative solution. Figure out if you want to however try the solution I first suggested, but I think the existing one solves it very well too.

rori4 commented 5 years ago

We can't update the UTM url as it is a one of the spec properties (added to ipfs and can NOT be modified). This is described in the adex protocol. Here is the info about the AdUnit https://github.com/AdExNetwork/adex-protocol/blob/master/campaignSpec.md#spec-properties-added-to-ipfs-and-can-not-be-modified

Ivshti commented 5 years ago

This is also blocked by principle/security. Should we allow overriding the URL? This can lead to scams.

So this must be accompanied by a change in the ad view that will accept the override if it ONLY changes the UTM

@rori4

rori4 commented 5 years ago

@Ivshti We have discussed this with @dmngdsm that cloning of the AdUnit solves the issue. If you want to change the UTM just clone it.

Ivshti commented 5 years ago

You need to open a new campaign though. Is this fine?

ivopaunov commented 5 years ago

If you clone it it will not replace the previous one and will not be included in existing campaigns.

On Fri, Nov 8, 2019, 11:03 Ivo Georgiev notifications@github.com wrote:

Reopened #223 https://github.com/AdExNetwork/adex-platform/issues/223.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/AdExNetwork/adex-platform/issues/223?email_source=notifications&email_token=ACPQSWX6HAH3CUGZPHPY6EDQSUTOXA5CNFSM4JJWWRJ2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUXKKU2A#event-2782177896, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPQSWUKIGRCGWNR3L2ZUATQSUTOXANCNFSM4JJWWRJQ .

dmngdsm commented 5 years ago

It is fine, if you have a wrong ad unit that you wanted to rename, you would have to stop the campaign anyway.

Cloning is totally solving this problem for now, there's no need to waste time on it.