AmbireTech / adex-protocol-eth

Ethereum implementation of the Ambire Protocol: Ambire Wallet contracts and AdEx payment channels
https://www.ambire.com
MIT License
49 stars 24 forks source link

ENS registrar for user subdomains #78

Closed Ivshti closed 4 years ago

Ivshti commented 5 years ago

The goal is to allow users to easily register an ENS subdomain through their Identity contracts.

This would not require any changes to the Identity, as execute can be used to trigger the name registrarion; it would simply require a registrar that will be set for adex.eth:

https://github.com/ensdomains/ens/blob/master/contracts/FIFSRegistrar.sol

See this as an example of what the Identity will do, once the user decides to register a username: https://github.com/UniversalLogin/UniversalLoginSDK/blob/master/universal-login-contracts/contracts/utils/ENSUtils.sol

Unlike the Universal login SDK, we won't force users into picking a username, it will be an entirely optional step that happens after registration

This is a simple task, but must be done within the team (hence no gitcoin-candidate) cause it requires nailing down a few important details; using a simple registrar won't be completely trustless, as we can change it at any time; to fix this, there must be a SC that owns the name completely; we will start with the simple FIFSRegistrar, and this could be an upgrade later down the line

a more trustless solution can be seen here: https://github.com/ensdomains/subdomain-registrar ; we won't use this, since we simply want a FIFSregistrar for our users

requirements:

see also:

Ivshti commented 4 years ago

This is done: https://etherscan.io/address/0xa3f69f48d4a45419d48b56b1cfbf4af2d4586728#code